[webkit-reviews] review granted: [Bug 89365] Web Inspector: Geolocation override : [Attachment 153862] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted  review:
Bug 89365: Web Inspector: Geolocation override
https://bugs.webkit.org/show_bug.cgi?id=89365

Attachment 153862: Patch
https://bugs.webkit.org/attachment.cgi?id=153862&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153862&action=review


>>>> Source/WebCore/inspector/front-end/SettingsScreen.js:665
>>>> +	      checkboxElement.checked = false;
>>> 
>>> Do you want to store this setting? Otherwise re-opening the front-end will
reset its state. See the way device metrics implements it.
>> 
>> I can change the line above to be:
>> checkboxElement.checked = !geolocation || (((typeof geolocation.latitude ===
"number") && (typeof geolocation.longitude === "number")) ||
geolocation.error);
>> OR
>> I can add a second setting to determine whether the element should be
checked or not, but this is not what device metrics does.
>> If we want this setting enabled right away when the inspector is connected
what signal or event shouldI listen for? Is there an example that I could
follow, because I don't see anything about device metrics that does this
either.
> 
> I can change the line above to be:
> checkboxElement.checked = !geolocation || (((typeof geolocation.latitude ===
"number") && (typeof geolocation.longitude === "number")) ||
geolocation.error);
> OR
> I can add a second setting to determine whether the element should be checked
or not, but this is not what device metrics does.
> If we want this setting enabled right away when the inspector is connected
what signal or event shouldI listen for? Is there an example that I could
follow, because I don't see anything about device metrics that does this
either.

Lets leave it non-saveable for now. I think it is time to land this change. Let
me land it and hide this override behind the experiment  until its UX is
polished!