[webkit-reviews] review denied: [Bug 90675] Web Inspector: implement testing harness for pure protocol tests. : [Attachment 154316] Work-in-progress patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 90675: Web Inspector: implement testing harness for pure protocol tests.
https://bugs.webkit.org/show_bug.cgi?id=90675

Attachment 154316: Work-in-progress patch
https://bugs.webkit.org/attachment.cgi?id=154316&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154316&action=review


> Source/WebCore/testing/Internals.cpp:132
> +    InspectorFrontendChannelDummy(Page*);

Mising explicit.

> Source/WebCore/testing/Internals.cpp:1073
> +    pc.chromeClient = new EmptyChromeClient();

All these clients must be deleted when the page closes.

> Source/WebCore/testing/Internals.cpp:1091
> +    delete m_frontendPage;

Please use OwnPtr instead of a raw pointer for storing the page to avoid
possible memory leaks if closeDummyInspectorFrontend is not called. Also we
should probably enforce the frontend closing when test completes.