[webkit-reviews] review denied: [Bug 92236] [Chromium][Win] <progress> animation on RTL direction is reverse : [Attachment 154319] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Hajime Morrita
<morrita at google.com>'s request for review:
Bug 92236: [Chromium][Win] <progress> animation on RTL direction is reverse
https://bugs.webkit.org/show_bug.cgi?id=92236

Attachment 154319: Patch
https://bugs.webkit.org/attachment.cgi?id=154319&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154319&action=review


> Source/WebCore/rendering/RenderThemeChromiumLinux.cpp:361
> +    saveTransformIfNecessary(o, i, rect);
>      PlatformSupport::paintThemePart(i.context,
PlatformSupport::PartProgressBar, getWebThemeState(this, o), rect,
&extraParams);

The function name 'saveTransformIfNecessary' isn't good for code readability.
A reader can't understand what is done in saveTransformIfNecessary.

Also, we had better use RAII idiom.