[webkit-reviews] review canceled: [Bug 92227] [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented : [Attachment 154287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 25 04:34:33 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 92227: [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be
implemented
https://bugs.webkit.org/show_bug.cgi?id=92227

Attachment 154287: Patch
https://bugs.webkit.org/attachment.cgi?id=154287&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
1. Rename WKBundleIntentRequestCopyIntent() to
WKBundleIntentRequestCopyIntentData() as suggested by Kenneth
2. Add explicit keyword for InjectedBundleIntentRequest constructor as spotted
by Gyuyoung
3. Rebase on master (the ewk_view showing trick is not longer needed as it was
fixed in a separate patch that landed)


More information about the webkit-reviews mailing list