[webkit-reviews] review canceled: [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface : [Attachment 154272] Patch

[bugzilla-daemon at webkit.org]

KwangYong Choi <ky0.choi at samsung.com> has canceled KwangYong Choi
<ky0.choi at samsung.com>'s request for review:
Bug 91832: [EFL][WK2] Implemented color chooser proxy and input picker
interface
https://bugs.webkit.org/show_bug.cgi?id=91832

Attachment 154272: Patch
https://bugs.webkit.org/attachment.cgi?id=154272&action=review

------- Additional Comments from KwangYong Choi <ky0.choi at samsung.com>
1. Changed bug title.

2. Moved member variables to proper position.

3. Removed priv->inputPicker = nullptr;

4. Moved "*" to proper position and changed variable names.

5. Moved allocation of InputPicker routine to Ewk_View_Private_Data
constructor.

6. Made early return.

7. ewk_view_color_chooser_color_set() function accepts all color formats webkit
can recognize. For example, named color can be used. So, I removed color format
example.

8. The initial value is passed when the InputPicker::show() is called. After
that, UI can change values and sets the value user choose. I think the function
to get the value is not necessary right now.

9. Added Eina_Bool return type for external api functions.