[webkit-reviews] review granted: [Bug 91398] Fix blend filter for autovectorizing : [Attachment 154292] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 91398: Fix blend filter for autovectorizing
https://bugs.webkit.org/show_bug.cgi?id=91398

Attachment 154292: Patch
https://bugs.webkit.org/attachment.cgi?id=154292&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154292&action=review


I'd r+ this as-is, though it doesn't apply on the bots. Still r=me, please
watch the bots to make sure it builds everywhere.
Thanks Allan, I'm now fully satisfied with your solution!

> Source/WebCore/platform/graphics/filters/FEBlend.cpp:74
> +inline unsigned char normal(unsigned char colorA, unsigned char colorB,
unsigned char alphaA, unsigned char)

You could just rename this to "feBlendNormal", this will reduce the likelihood
of clashes in all-in-one builds a lot.