[webkit-reviews] review denied: [Bug 92217] A validation bubble should not be modifiable : [Attachment 154296] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 25 02:07:57 PDT 2012
Kent Tamura <tkent at chromium.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 92217: A validation bubble should not be modifiable
https://bugs.webkit.org/show_bug.cgi?id=92217
Attachment 154296: Patch
https://bugs.webkit.org/attachment.cgi?id=154296&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154296&action=review
> Source/WebCore/ChangeLog:19
> + (::-webkit-validation-bubble):
> + (::-webkit-validation-bubble-message):
> + (::-webkit-validation-bubble-text-block):
> + (::-webkit-validation-bubble-heading):
> + (::-webkit-validation-bubble-arrow):
> + (::-webkit-validation-bubble-arrow-clipper):
Write what you changed and the reason.
> LayoutTests/ChangeLog:9
> + * fast/forms/validation-user-modify.html: Added.
The test file name should start with validation-message- to follow other
existing tests.
> LayoutTests/fast/forms/validation-user-modify.html:31
> +if (window.testRunner)
> + testRunner.waitUntilDone();
should be replaced with jsTestIsAsync = true;.
> LayoutTests/fast/forms/validation-user-modify.html:52
> + if (window.testRunner)
> + testRunner.notifyDone();
should be replaced with finishJSTest();.
More information about the webkit-reviews
mailing list