[webkit-reviews] review granted: [Bug 92214] Remove anonymous namespace and make functions static. : [Attachment 154266] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 23:43:26 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 92214: Remove anonymous namespace and make functions static.
https://bugs.webkit.org/show_bug.cgi?id=92214

Attachment 154266: Patch
https://bugs.webkit.org/attachment.cgi?id=154266&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154266&action=review


> Source/WebCore/html/parser/create-html-entity-table:-112
> -namespace {

I would actually leave this one.  There are a ton of symbols in here that would
be good to hide from the linker.


More information about the webkit-reviews mailing list