[webkit-reviews] review granted: [Bug 92202] RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode : [Attachment 154238] Use logical coordinates consistently and correctly

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted mitz at webkit.org's request for review:
Bug 92202: RenderBlock::positionForPoint can fail when the block or its
children have a vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=92202

Attachment 154238: Use logical coordinates consistently and correctly
https://bugs.webkit.org/attachment.cgi?id=154238&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154238&action=review


> Source/WebCore/ChangeLog:12
> +	   one of the sub-tests in the new regression test: (1) changed to
compare children’s logical

Funny apostrophe character on children's?

> Source/WebCore/ChangeLog:13
> +	   bounds against pointInLogicalContents, i.e. compare childern’s
horizontal bounds to the

Here too.

> Source/WebCore/ChangeLog:14
> +	   point’s horizontal component; and (2) changed to use
logicalTopForChild and

Here too.

> Source/WebCore/ChangeLog:15
> +	   logicalHeightForChild, which account for this block’s writing
mode, instead of logicalTop

And here.

> Source/WebCore/ChangeLog:16
> +	   and logicalBottom, which are based on the child’s writing mode.

And here. :-P