[webkit-reviews] review granted: [Bug 92109] Implement ColorSuggestionPicker page popup : [Attachment 154222] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 20:26:59 PDT 2012


Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92109: Implement ColorSuggestionPicker page popup
https://bugs.webkit.org/show_bug.cgi?id=92109

Attachment 154222: Patch
https://bugs.webkit.org/attachment.cgi?id=154222&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154222&action=review


> Source/WebCore/Resources/colorSuggestionPicker.js:28
> +var global = {
> +    argumentsReceived: false
> +};

Making 'global' object only for 'argumentsReceived' flag is overkill.
We had better remove global, or add scrollbarWidth to global.


More information about the webkit-reviews mailing list