[webkit-reviews] review granted: [Bug 92184] [chromium] Move renderingStats from WebView to WebWidget. : [Attachment 154194] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 18:04:43 PDT 2012


Adam Barth <abarth at webkit.org> has granted Dave Tu <dtu at chromium.org>'s request
for review:
Bug 92184: [chromium] Move renderingStats from WebView to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=92184

Attachment 154194: Patch
https://bugs.webkit.org/attachment.cgi?id=154194&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154194&action=review


> Source/WebKit/chromium/public/WebWidget.h:226
> +    // Fills in a WebRenderingStats struct containing information about the
state of the compositor.
> +    // This call is relatively expensive in threaded mode as it blocks on
the compositor thread.

This comment seems slightly at odds with the ChangeLog.

This patch is fine, but it would be valuable to add some more information to
the ChangeLog about why we're making this change.  Maybe just an example? 
Certainly not a big deal, but it can be helpful to folks reading these patches.


More information about the webkit-reviews mailing list