[webkit-reviews] review granted: [Bug 88778] [CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedFlow object : [Attachment 152736] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 88778: [CSS Regions] The regionLayoutUpdate event should be dispatched on
the NamedFlow object
https://bugs.webkit.org/show_bug.cgi?id=88778

Attachment 152736: Patch
https://bugs.webkit.org/attachment.cgi?id=152736&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152736&action=review


I didn't review the tests that carefully because I presume these are reworks of
the tests you're removing.

> Source/WebCore/ChangeLog:17
> +	   No new tests (OOPS!).

This line will prevent the patch from landing.	Can you update this to list the
test that you've added?

> Source/WebCore/dom/WebKitNamedFlow.h:65
> +    virtual const AtomicString& interfaceName() const;
> +    virtual ScriptExecutionContext* scriptExecutionContext() const;

We've been adding the OVERRIDE keyword to overrides of these functions.