[webkit-reviews] review granted: [Bug 92168] [V8] Correct WebIDL type should be used in the testing IDL file : [Attachment 154159] Proposed Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 92168: [V8] Correct WebIDL type should be used in the testing IDL file
https://bugs.webkit.org/show_bug.cgi?id=92168

Attachment 154159: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=154159&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154159&action=review


> Source/WebCore/bindings/scripts/test/TestObj.idl:193
> +	   [V8EnabledAtRuntime=FeatureName] void enabledAtRuntimeMethod2(in
long intArg);

Let's rename to longArg.

> Source/WebCore/bindings/scripts/test/TestObj.idl:198
> +	   [V8EnabledPerContext] void enabledPerContextMethod1(in long intArg);

> +	   [V8EnabledPerContext=FeatureName] void enabledPerContextMethod2(in
long intArg);

Ditto.