[webkit-reviews] review granted: [Bug 91700] make test-webkitpy at least kinda work in parallel on win32 : [Attachment 153156] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 15:04:56 PDT 2012


Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 91700: make test-webkitpy at least kinda work in parallel on win32
https://bugs.webkit.org/show_bug.cgi?id=91700

Attachment 153156: Patch
https://bugs.webkit.org/attachment.cgi?id=153156&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153156&action=review


> Tools/Scripts/new-run-webkit-tests:31
> +from  webkitpy.common import multiprocessing_bootstrap

Looks like you've got an extra space after the "from"

> Tools/Scripts/webkitpy/test/main.py:45
> +    webkit_root = up(up(up(up(up(os.path.abspath(__file__))))))

up up and away!


More information about the webkit-reviews mailing list