[webkit-reviews] review requested: [Bug 91894] Search cancel button is hard to activate with a tap gesture even if touch adjustment is enabled. : [Attachment 153575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 12:02:26 PDT 2012


Kevin Ellis <kevers at chromium.org> has asked  for review:
Bug 91894: Search cancel button is hard to activate with a tap gesture even if
touch adjustment is enabled.
https://bugs.webkit.org/show_bug.cgi?id=91894

Attachment 153575: Patch
https://bugs.webkit.org/attachment.cgi?id=153575&action=review

------- Additional Comments from Kevin Ellis <kevers at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153575&action=review


>> Source/WebCore/page/TouchAdjustment.cpp:77
>> +	Node* ancestorNode = node->shadowAncestorNode();
> 
> should not you use ::shadowHost instead?
> 
> see bug 91966

Done.


More information about the webkit-reviews mailing list