[webkit-reviews] review requested: [Bug 90321] Convert HTML parser to handle 8-bit resources without converting to UChar* : [Attachment 154114] Updated patch with performance tunes for Parsing Tests

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 90321: Convert HTML parser to handle 8-bit resources without converting to
UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Attachment 154114: Updated patch with performance tunes for Parsing Tests
https://bugs.webkit.org/attachment.cgi?id=154114&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
(In reply to comment #22)
> (From update of attachment 152676 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=152676&action=review
> 
> r=me, but make sure you checked that html parser perf is still okay.	Check
with eseidel, abarth, or antti as I believe that there is a html parser
benchmark in the repo somewhere.

The prior patch was a regression to neutral on the parsing tests.  This
reworking of the patch has tunes to turn all but one test into progressions.

The table below shows the test results.  I restarted Safari before each test. 
The units and better direction is listed below the test.

Test				r123007   r123011 and	Delta
				baseline   this patch
css-parser-yui	       Average	  368.65     367.76	-0.24%
(runs/sec)	       Median	  368.42     368.66	 0.07%
(Bigger is better)     StDev	    2.12       2.57
	
html-parser	       Average	 1900.05    1856.50	 2.29%
(ms)		       Median	 1903.50    1857.50	 2.42%
(Smaller is better)    StDev	   11.97       5.12
	
html5-full-render      Average	20524	   20381.5	 0.69%
(ms)		       Median	20524	   20381.5	 0.69%
(Smaller is better)    StDev	  219	     198.5

innerHTML-setter       Average	  289.67     295.67	 2.07%
(runs/sec)	       Median	  289.86     296.11	 2.16%
(Bigger is better)     StDev	    1.43       1.66

query-selector-deep    Average	  386.64     395.68	 2.34%
(runs/sec)	       Median	  386.47     395.55	 2.35%
(Bigger is better)     StDev	    1.15       1.09

query-selector-first   Average	  2108.09   2031.64	-3.63%
(runs/sec)	       Median	  2108.04   2034.33	-3.50%
(Bigger is better)     StDev	    21.37     17.72

query-selector-last    Average	   372.19    389.22	 4.58%
(runs/sec)	       Median	   372.34    389.29	 4.55%
(Bigger is better)     StDev	     0.94      0.67

simple-url	       Average	    43.00     48.88	13.69%
(runs/sec)	       Median	    42.99     49.26	14.59%
(Bigger is better)     StDev	     0.24      0.65

textarea-parsing       Average	    56.49     56.27	-0.38%
(runs/sec)	       Median	    56.63     56.37	-0.45%
(Bigger is better)     StDev	     0.72      0.56

tiny-innerHTML	       Average	     5.68      6.36	12.02%
(runs/sec)	       Median	     5.68      6.37	12.03%
(Bigger is better)     StDev	     0.05      0.04

url-parser	       Average	    96.96     113.65	17.20%
(runs/sec)	       Median	    97.03     113.71	17.19%
(Bigger is better)     StDev	     1.09      0.56

xml-parser	       Average	     6.89      7.09	2.81%
(runs/sec)	       Median	     6.90      7.10	2.84%
(Bigger is better)     StDev	     0.04      0.03