[webkit-reviews] review granted: [Bug 92052] Fix regressions in replay performance tests : [Attachment 153953] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 92052: Fix regressions in replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92052

Attachment 153953: Patch
https://bugs.webkit.org/attachment.cgi?id=153953&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153953&action=review


> Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:198
> +	  
self.assertEqual(port.host.filesystem.files['/path/some-dir/some-test-actual.pn
g'], 'actual image')

I try to keep clients of the mock filesystem from actually accessing files; it
should probably be _files instead. Can you change this to
filesystem.read_binary_file()?

> Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:285
> +	  
self.assertEqual(port.host.filesystem.files['/path/some-dir/some-test-expected.
png'], 'actual image')

same thing ...