[webkit-reviews] review denied: [Bug 92040] Disable delete from contextmenu on password fields : [Attachment 153933] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Carlos <carloschilazo at gmail.com>'s
request for review:
Bug 92040: Disable delete from contextmenu on password fields
https://bugs.webkit.org/show_bug.cgi?id=92040

Attachment 153933: Patch
https://bugs.webkit.org/attachment.cgi?id=153933&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153933&action=review


> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:178
> -    if (m_webView->focusedWebCoreFrame()->editor()->canDelete())
> +    // Delete is not currently available for password fields: Webkit bug
92040.
> +    if (m_webView->focusedWebCoreFrame()->editor()->canDelete() &&
!selectedFrame->selection()->isInPasswordField())

I don't think this is the right fix. We should be able to delete text in
password fields.