[webkit-reviews] review granted: [Bug 92065] Ensure Noah's ark without reading the DOM tree. : [Attachment 154038] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 92065: Ensure Noah's ark without reading the DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=92065

Attachment 154038: Patch
https://bugs.webkit.org/attachment.cgi?id=154038&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154038&action=review


> Source/WebCore/html/parser/HTMLFormattingElementList.cpp:134
> -void HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly(Element*
newElement, Vector<Element*>& remainingCandidates)
> +void
HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly(HTMLStackItem*
newItem, Vector<HTMLStackItem*>& remainingCandidates)

Yeah, this function is very hot.

> Source/WebCore/html/parser/HTMLStackItem.h:60
> +    const AtomicString& localName() const { return m_token->name(); }

I assume that m_token->name() is already an AtomicString.