[webkit-reviews] review granted: [Bug 91251] [V8] String wrappers should be Independent : [Attachment 153976] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 10:24:07 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 91251: [V8] String wrappers should be Independent
https://bugs.webkit.org/show_bug.cgi?id=91251

Attachment 153976: Patch
https://bugs.webkit.org/attachment.cgi?id=153976&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153976&action=review


> Source/WebCore/ChangeLog:40
> +	   Without 'm_lastStringImpl = 0', already disposed m_lastV8String can
be used
> +	   in v8ExternalString(). This was a cause of the crashes of r122614.

Ah.  Interesting.


More information about the webkit-reviews mailing list