[webkit-reviews] review granted: [Bug 91295] Add per-context setting for html notifications : [Attachment 153928] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 10:19:37 PDT 2012


Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 91295: Add per-context setting for html notifications
https://bugs.webkit.org/show_bug.cgi?id=91295

Attachment 153928: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=153928&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153928&action=review


If haraken is happy with the V8 pieces, I'm happy with the notification pieces.
 Let's rock and roll.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2623
> +	     push(@enabledPerContextFunctions, $function);

Four-space indent please.


More information about the webkit-reviews mailing list