[webkit-reviews] review granted: [Bug 91771] create SourceBuffer and SourceBufferList objects : [Attachment 153898] no diff, hoping win bot will run this time

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 10:08:23 PDT 2012


Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 91771: create SourceBuffer and SourceBufferList objects
https://bugs.webkit.org/show_bug.cgi?id=91771

Attachment 153898: no diff, hoping win bot will run this time
https://bugs.webkit.org/attachment.cgi?id=153898&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153898&action=review


> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:59
> +    UNUSED_PARAM(data);
> +    // FIXME(91773): append the data to the media source.

Nit: UNUSED_PARAM() isn't necessary if you don't name the parameter.


More information about the webkit-reviews mailing list