[webkit-reviews] review granted: [Bug 92056] Clear the external characters pointer of an AtomicHTMLToken before the raw token is cleared. : [Attachment 153938] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 92056: Clear the external characters pointer of an AtomicHTMLToken before
the raw token is cleared.
https://bugs.webkit.org/show_bug.cgi?id=92056

Attachment 153938: Patch
https://bugs.webkit.org/attachment.cgi?id=153938&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153938&action=review


> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:459
> +    if (token->type() == HTMLTokenTypes::Character)
> +	   token->clearExternalCharacters();

I would just do this unconditionally.  There isn't any harm in overwriting
m_externalCharacters with 0 for other token types and it saves us this branch.