[webkit-reviews] review canceled: [Bug 90381] [JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray() using traits. : [Attachment 152519] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 08:27:13 PDT 2012


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has canceled Vineet Chaudhary
(vineetc) <rgf748 at motorola.com>'s request for review:
Bug 90381: [JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray()
using traits.
https://bugs.webkit.org/show_bug.cgi?id=90381

Attachment 152519: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=152519&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
@haraken 
I confirmed as jsValue.isNumber() and jsValue.isUndefinedOrNull() are different
checks so if 
irrespective  isUndefinedOrNull() true or false jsValue should be JSNumber so
we can remove the isUndefinedOrNull() check here.


More information about the webkit-reviews mailing list