[webkit-reviews] review denied: [Bug 92114] Add methods to ColorChooserClient so the color chooser can show suggestions : [Attachment 154065] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92114: Add methods to ColorChooserClient so the color chooser can show
suggestions
https://bugs.webkit.org/show_bug.cgi?id=92114

Attachment 154065: Patch
https://bugs.webkit.org/attachment.cgi?id=154065&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154065&action=review


> Source/WebCore/html/ColorInputType.cpp:231
> +	       suggestions.append(Color(option->value()));

We should check Color::isValid() because HTMLOptionElement::value() might have
an invalid string.
Also, we shouldn't accept named color like "white".