[webkit-reviews] review granted: [Bug 92114] Add methods to ColorChooserClient so the color chooser can show suggestions : [Attachment 154056] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 07:37:35 PDT 2012


Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92114: Add methods to ColorChooserClient so the color chooser can show
suggestions
https://bugs.webkit.org/show_bug.cgi?id=92114

Attachment 154056: Patch
https://bugs.webkit.org/attachment.cgi?id=154056&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154056&action=review


> Source/WebCore/html/ColorInputType.cpp:215
> +    return element()->fastHasAttribute(HTMLNames::listAttr);

We usually declare "using namespace HTMLNames;" and omit HTMLNames::.


More information about the webkit-reviews mailing list