[webkit-reviews] review denied: [Bug 92096] Move PagePopupClient helper functions so they can be shared : [Attachment 154036] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 92096: Move PagePopupClient helper functions so they can be shared
https://bugs.webkit.org/show_bug.cgi?id=92096

Attachment 154036: Patch
https://bugs.webkit.org/attachment.cgi?id=154036&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154036&action=review


> Source/WebCore/page/PagePopupClient.h:52
> +    // Helper functions to be used in PagePopupClient::writeDocument().
> +    static void addString(const String&, DocumentWriter&);
> +    static void addJavaScriptString(const String&, DocumentWriter&);
> +    static void addProperty(const char* name, const String& value,
DocumentWriter&);
> +    static void addProperty(const char* name, unsigned value,
DocumentWriter&);
> +    static void addProperty(const char* name, bool value, DocumentWriter&);
> +    static void addProperty(const char* name, const Vector<String>& values,
DocumentWriter&);

Please move them to the bottom of the class definition.  Pure virtual functions
are more important than static helper functions.