[webkit-reviews] review canceled: [Bug 90268] [WK2][GTK] Implement a new spell checker API for WebKit2GTK+ : [Attachment 153519] Patch proposal + Unit tests + Documentation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 04:48:48 PDT 2012


Mario Sanchez Prada <msanchez at igalia.com> has canceled Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 90268: [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=90268

Attachment 153519: Patch proposal + Unit tests + Documentation
https://bugs.webkit.org/attachment.cgi?id=153519&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #10)
> I think it's a good first step. If we need the interface later, perhaps we
can add it (precisely the way we did for WebKit1). Carlos, what are your
thoughts?

I'm attaching a new patch using this (quite simpler) approach. I basically
added just two new files (WebKitTextChecker.[h|cpp]) providing a new internal
C++ class that will serve both to provide an implementation for the
TextCheckerClient (so calls from WebCore will work) and to have an object which
WebKitWebContext can rely on to implement the newly added API.

If in the future we want to go back to the previous approach we can always do
it, but now I see this other implementation I think it makes sense and probably
good enough (bonus points for the patch being half big than the previous one!)

Asking for review now


More information about the webkit-reviews mailing list