[webkit-reviews] review denied: [Bug 91991] Web Inspector: Timeline: avoid "IPC message too big" on save/load : [Attachment 153790] Patch

[bugzilla-daemon at webkit.org]

Ilya Tikhonovsky <loislo at chromium.org> has denied eustas.bug at gmail.com's
request for review:
Bug 91991: Web Inspector: Timeline: avoid "IPC message too big" on save/load
https://bugs.webkit.org/show_bug.cgi?id=91991

Attachment 153790: Patch
https://bugs.webkit.org/attachment.cgi?id=153790&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153790&action=review


Looks like the existing implementation has bad design. Could you please fix it
(replace the callbacks with delegate interface) in the first patch and extract
the code into separate file in the second or vice versa.

> Source/WebCore/inspector/front-end/FileUtils.js:101
> +	* @param {function(WebInspector.HeapSnapshotProxy)=} callback

please remove this

> Source/WebCore/inspector/front-end/FileUtils.js:110
> +	   return true;

why do we need a return value here