[webkit-reviews] review granted: [Bug 76225] [chromium] Hint garbage collector to run if page uses Canvas contexts : [Attachment 153596] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 76225: [chromium] Hint garbage collector to run if page uses Canvas
contexts
https://bugs.webkit.org/show_bug.cgi?id=76225

Attachment 153596: Patch
https://bugs.webkit.org/attachment.cgi?id=153596&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153596&action=review


Marking r+ based on the following points:
- danno says OK.
- This change affects V8 only.
- The implementation looks good to me.

BTW, is page navigation the only concern? For example, the test case in this
patch is creating a lot of canvases without navigating pages.

> Source/WebCore/bindings/v8/V8Binding.cpp:114
> +void V8BindingPerIsolateData::setLowMemoryNotificationHint(bool hint)
> +{
> +    m_lowMemoryNotificationHint = hint;
> +}
> +
> +bool V8BindingPerIsolateData::getLowMemoryNotificationHint() const
> +{
> +    return m_lowMemoryNotificationHint;
> +}

Nit: You can write them in the header file.

> Source/WebCore/bindings/v8/V8Binding.h:228
> +	   void setLowMemoryNotificationHint(bool);
> +	   bool getLowMemoryNotificationHint() const;

Nit: I would prefer setLowMemoryNotificationHint(),
clearLowMemoryNotificationHint() and isLowMemoryNotificationHint().

> LayoutTests/fast/canvas/webgl/context-creation-and-destruction.html:12
> +<div id="description"></div>
> +<div id="console"></div>

Nit: These are not needed. Will be added automatically.