[webkit-reviews] review denied: [Bug 89365] Web Inspector: Geolocation override : [Attachment 153862] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 89365: Web Inspector: Geolocation override
https://bugs.webkit.org/show_bug.cgi?id=89365

Attachment 153862: Patch
https://bugs.webkit.org/attachment.cgi?id=153862&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153862&action=review


As per comments for previous patch. Btw, there is no need to submit patches
unless comments are addressed.

> Source/WebCore/inspector/front-end/SettingsScreen.js:665
> +	   checkboxElement.checked = false;

Do you want to store this setting? Otherwise re-opening the front-end will
reset its state. See the way device metrics implements it.