[webkit-reviews] review denied: [Bug 63244] [Qt] Fix tst_QWebPage::showModalDialog() API test : [Attachment 152507] Remove QEXPECT_FAIL for tests marked as XPASS.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Sergio Ahumada
<sergio.ahumada at nokia.com>'s request for review:
Bug 63244: [Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244

Attachment 152507: Remove QEXPECT_FAIL for tests marked as XPASS.
https://bugs.webkit.org/attachment.cgi?id=152507&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Hmm, in principle this sounds okay to me. But the patch doesn't apply, it uses
src/3rdparty/webkit as prefix. Did you make this patch against Qt 4.8? It
sounds like it needs to be rebased against WebKit trunk.

The patch is also missing a ChangeLog entry.