[webkit-reviews] review granted: [Bug 80269] [Microdata] Implement PropertyNodeList interface. : [Attachment 153779] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 23 22:28:24 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Arko Saha <arko at motorola.com>'s
request for review:
Bug 80269: [Microdata] Implement PropertyNodeList interface.
https://bugs.webkit.org/show_bug.cgi?id=80269
Attachment 153779: Updated patch
https://bugs.webkit.org/attachment.cgi?id=153779&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153779&action=review
> Source/WebCore/dom/PropertyNodeList.cpp:61
> + return false;
Nit: Wrong indentation
> Source/WebCore/dom/PropertyNodeList.cpp:99
> + unsigned offset = 0;
> +
> + while (Node* node = item(offset)) {
Use for loop instead so that you can declare offset in the for loop.
More information about the webkit-reviews
mailing list