[webkit-reviews] review granted: [Bug 91661] [Chromium] Support scrolling and zooming to focused input elements : [Attachment 153857] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 91661: [Chromium] Support scrolling and zooming to focused input elements
https://bugs.webkit.org/show_bug.cgi?id=91661

Attachment 153857: Patch
https://bugs.webkit.org/attachment.cgi?id=153857&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153857&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:201
> +static const double scrollFocusedNodeAnimationDurationInSeconds = 0.2;

nit: since this is used with restoreScrollAndScaleState, it may be used in
cases
that don't involve the focused node.  maybe call it
scrollAndScaleAnimationDurationInSeconds?

> Source/WebKit/chromium/src/WebViewImpl.cpp:2730
> +#if ENABLE(GESTURE_EVENTS)

nit: not sure why this is protected by GESTURE_EVENTS feature guard, but that's
ok.

> Source/WebKit/chromium/src/WebViewImpl.cpp:2743
> +    m_savedScrollOffset = WebSize();

... = IntSize();

> Source/WebKit/chromium/src/WebViewImpl.h:724
> +    WebSize m_savedScrollOffset;

nit: use IntSize instead.  better to use WebCore types in the implementation.