[webkit-reviews] review canceled: [Bug 92061] Reimplement RenderQuote to be simpler and safer (and also doesn't follow the spec) : [Attachment 153950] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 23 21:46:33 PDT 2012
Elliott Sprehn <esprehn at gmail.com> has canceled Elliott Sprehn
<esprehn at gmail.com>'s request for review:
Bug 92061: Reimplement RenderQuote to be simpler and safer (and also doesn't
follow the spec)
https://bugs.webkit.org/show_bug.cgi?id=92061
Attachment 153950: Patch
https://bugs.webkit.org/attachment.cgi?id=153950&action=review
------- Additional Comments from Elliott Sprehn <esprehn at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153950&action=review
> Source/WebCore/rendering/RenderObjectChildList.cpp:-211
> - toRenderRegion(newChild)->attachRegion();
This shouldn't have been removed. Code refactoring fail.
> Source/WebCore/rendering/RenderQuote.h:-31
> - RenderQuote(Document*, const QuoteType);
Should be const, and m_type should be const too.
More information about the webkit-reviews
mailing list