[webkit-reviews] review denied: [Bug 91322] WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame : [Attachment 153901] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Hanyee Kim
<choco at company100.net>'s request for review:
Bug 91322: WebKit does not retain final value of opacity in animations, unless
it is specified on the last key frame
https://bugs.webkit.org/show_bug.cgi?id=91322

Attachment 153901: Patch
https://bugs.webkit.org/attachment.cgi?id=153901&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153901&action=review


Thanks for catching this! Some nitpicks but otherwise good.

> Source/WebCore/ChangeLog:4
> +	   WebKit does not retain final value of opacity in animations, unless
it is specified on the last key frame
> +	   https://bugs.webkit.org/show_bug.cgi?id=91322

This bug currently affects TextureMapper only (since other ports of
GraphicsLayer don't use this file). That should be portrayed in the bug
description and Changelog.

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp:54
> +	   return 1.0;

Use 1 instead of 1.0.

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp:57
> +    return shouldReverseAnimationValue(direction, iterationCount) ? 1.0 : 0;


ditto