[webkit-reviews] review denied: [Bug 92040] Delete text from password does nothing, proposed fix : [Attachment 153892] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Carlos <carloschilazo at gmail.com>'s
request for review:
Bug 92040: Delete text from password does nothing, proposed fix
https://bugs.webkit.org/show_bug.cgi?id=92040

Attachment 153892: Patch
https://bugs.webkit.org/attachment.cgi?id=153892&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153892&action=review


> Source/WebCore/editing/EditorCommand.cpp:1238
> -	   return enabledCut(frame, event, source);
> +	   return enabledInEditableText(frame, event, source);

If we're making this change, then we should just delete this function and
replace the reference in createCommandMap by enabledInEditableText.
Now, according to http://trac.webkit.org/changeset/29300 which added this code,
we'll end up enabling the delete in an empty text field by making this change
but that'll be a regression. r- because of this.