[webkit-reviews] review denied: [Bug 86179] [Qt] tab-size CSS property doesn't work at all : [Attachment 147619] "Force tab size layout test to use monospace" patch

Mon Jul 23 15:00:32 PDT 2012

Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org> has denied Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 86179: [Qt] tab-size CSS property doesn't work at all
https://bugs.webkit.org/show_bug.cgi?id=86179

Attachment 147619: "Force tab size layout test to use monospace" patch
https://bugs.webkit.org/attachment.cgi?id=147619&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147619&action=review

> LayoutTests/fast/css/tab-size.html:43
> +<body style="font-family:'monospace'" onload="test();">
>  <div id="template" style="display:none;">
>  <pre>&Tab;x</pre>

Setting the style here is wrong. We are using <pre> tag and it should select a
monospace font in the test environment.