[webkit-reviews] review denied: [Bug 91702] File should use getMIMETypeForExtension when guessing content type. : [Attachment 153856] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 91702: File should use getMIMETypeForExtension when guessing content type.
https://bugs.webkit.org/show_bug.cgi?id=91702

Attachment 153856: Patch
https://bugs.webkit.org/attachment.cgi?id=153856&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153856&action=review


> Source/WebCore/fileapi/File.h:53
> +    static PassRefPtr<File> createWithRelativePathFromUserAction(const
String& path, const String& relativePath);

The new naming scheme seems to be a bit confusing. How about we make enum
public and force the caller to select the right creator to call for most cases,
sth like:
    enum FileOrigin {
	// The file is selected as a result of an user action, such as ...
	FromUserAction,
	// The file is created ...
	FromSystem
    };

    static PassRefPtr<File> create(FileOrigin, const String& path)

    // Create a file with a name exposed to the author ...
    static PassRefPtr<File> createWithName(FileOrigin, const String& path,
const String& name)

    // For deserialization.
    static PassRefPtr<File> create(const String& path, const KURL& srcURL,
const String& type)

#if ENABLE(DIRECTORY_UPLOAD)
    // FromUserAction is assumed.
    static PassRefPtr<File> createWithRelativePath(const String& path, const
String& relativePath)
#endif

#if ENABLE(FILE_SYSTEM)
    // FromSystem is assumed.
    static PassRefPtr<File> createForFileSystemFile(const String& name, const
FileMetadata& metadata)
#endif