[webkit-reviews] review granted: [Bug 91541] [BlackBerry] Move about: URL handling out of WebCore : [Attachment 153852] More cleanups

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 23 13:58:44 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Yong Li <yoli at rim.com>'s request for
review:
Bug 91541: [BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541

Attachment 153852: More cleanups
https://bugs.webkit.org/attachment.cgi?id=153852&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153852&action=review


Looks good.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:397
> +	       WTF::RefPtr<SharedBuffer> buffer =
SharedBuffer::create(source.is8Bit() ? reinterpret_cast<const
char*>(source.characters8()) : source.latin1().data(), source.length());

You forgot to remove the WTF:: prefix :)


More information about the webkit-reviews mailing list