[webkit-reviews] review granted: [Bug 92010] [Chromium] Move layoutTestMode to WebCore : [Attachment 153826] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 23 13:28:37 PDT 2012
Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 92010: [Chromium] Move layoutTestMode to WebCore
https://bugs.webkit.org/show_bug.cgi?id=92010
Attachment 153826: Patch
https://bugs.webkit.org/attachment.cgi?id=153826&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153826&action=review
> Source/WebCore/platform/LayoutTestMode.h:32
> +#ifndef LayoutTestMode_h
> +#define LayoutTestMode_h
I wonder if LayoutTestMode.h is still the right name for this header...
Perhaps LayoutTestSupport.h (just LayoutTest.h doesn't seem right)? Sorry to
be so nit-picky about the names. If you want to land it with this name, that's
fine too.
More information about the webkit-reviews
mailing list