[webkit-reviews] review canceled: [Bug 90720] [Mac] Do not perform 8 to 16bits characters conversion when converting a WTFString to NSString/CFString : [Attachment 151135] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 90720: [Mac] Do not perform 8 to 16bits characters conversion when
converting a WTFString to NSString/CFString
https://bugs.webkit.org/show_bug.cgi?id=90720

Attachment 151135: Patch
https://bugs.webkit.org/attachment.cgi?id=151135&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> > Source/WebCore/platform/text/cf/StringImplCF.cpp:139
> > +		 return CFStringCreateWithBytes(0, reinterpret_cast<const
UInt8*>(characters8()), m_length, kCFStringEncodingASCII, false);
> 
> I think this should be Latin-1 and not ASCII.

Oops, you are right, that could have ended up badly. I'll update.