[webkit-reviews] review granted: [Bug 90325] [chromium] Use shallow flushes that don't glFlush : [Attachment 153619] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Brian Anderson
<brianderson at chromium.org>'s request for review:
Bug 90325: [chromium] Use shallow flushes that don't glFlush
https://bugs.webkit.org/show_bug.cgi?id=90325

Attachment 153619: Patch
https://bugs.webkit.org/attachment.cgi?id=153619&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153619&action=review


Looks fine overall. One question. r=me; please mark cq? if the answer to the
question above is "yes".

> Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.cpp:105
> +		   resourceProvider->shallowFlushIfSupported();

Is the change from "flush" to "shallow flush" correct in all cases? In other
words, the flushes before were only to "kick" the command processor, and
weren't needed for correctness at the OpenGL level?