[webkit-reviews] review granted: [Bug 91973] [Chromium] Enable web audio IPP for x86 chromium android : [Attachment 153761] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 23 11:16:17 PDT 2012


Tony Chang <tony at chromium.org> has granted Wei James <james.wei at intel.com>'s
request for review:
Bug 91973: [Chromium] Enable web audio IPP for x86 chromium android
https://bugs.webkit.org/show_bug.cgi?id=91973

Attachment 153761: Patch
https://bugs.webkit.org/attachment.cgi?id=153761&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153761&action=review


> Source/WebCore/WebCore.gyp/WebCore.gyp:1234
> +	   ['OS in ["linux", "android"] and "WTF_USE_WEBAUDIO_IPP=1" in
feature_defines', {

Nit: Use a tuple () instead of a list [].

> Source/WebCore/WebCore.gyp/WebCore.gyp:1437
> +	   ['OS in ["linux", "android"] and "WTF_USE_WEBAUDIO_IPP=1" in
feature_defines', {

Nit: Use a tuple () instead of a list [].


More information about the webkit-reviews mailing list