[webkit-reviews] review granted: [Bug 92010] [Chromium] Move layoutTestMode to WebCore : [Attachment 153818] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 92010: [Chromium] Move layoutTestMode to WebCore
https://bugs.webkit.org/show_bug.cgi?id=92010

Attachment 153818: Patch
https://bugs.webkit.org/attachment.cgi?id=153818&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153818&action=review


> Source/WebCore/platform/LayoutTestMode.h:39
> +class LayoutTestMode {
> +public:
> +    static bool layoutTestMode();
> +    static void setLayoutTestMode(bool);

We don't really need this class wrapper.  We can just have layoutTestMode() and
setLayoutTestMode() exist in the WebCore namespace.

> Source/WebCore/platform/LayoutTestMode.h:44
> +    static bool isLayoutTestModeEnabled;

In that approach, this can just be a static in the LayoutTestMode.cpp file.

We might take this opportunity to rename these functions to
isRunningLayoutTest() or something else more WebKity.