[webkit-reviews] review granted: [Bug 91927] Fix WebGL texSubImage2D for cube maps : [Attachment 153668] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Gregg Tavares <gman at google.com>'s
request for review:
Bug 91927: Fix WebGL texSubImage2D for cube maps
https://bugs.webkit.org/show_bug.cgi?id=91927

Attachment 153668: Patch
https://bugs.webkit.org/attachment.cgi?id=153668&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153668&action=review


Nice fix. r=me with one comment. Let me know if you want me to cq+ it as is.

> Source/WebCore/html/canvas/WebGLRenderingContext.h:592
> +				      bool subImage2d);

FYI, there's a preference in WebKit to use local enums instead of boolean
arguments to avoid the problem of confusing "true, true, false" call sites. I
don't think this is that big a deal here but just something to keep in mind.
Here it could be enum { ForTexSubImage2D, NotForTexSubImage2D }.