[webkit-reviews] review granted: [Bug 91761] [CSS Exclusions] SVG shape errors should invalidate exclusion shapes : [Attachment 153609] Updated patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 91761: [CSS Exclusions] SVG shape errors should invalidate exclusion shapes
https://bugs.webkit.org/show_bug.cgi?id=91761

Attachment 153609: Updated patch
https://bugs.webkit.org/attachment.cgi?id=153609&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153609&action=review


r=me though we should really add comments to make it clear why we're
selectively disallowing negative numbers.

> Source/WebCore/css/CSSParser.cpp:4470
> +	   if (argumentNumber > 1) 
> +	       unitFlags = unitFlags | FNonNeg;

Could use a comment - something simple like "// Disallow negative values for
width/height."

> Source/WebCore/css/CSSParser.cpp:4526
> +	   if (argumentNumber == 2)
> +	       unitFlags = unitFlags | FNonNeg;

Ditto.

> Source/WebCore/css/CSSParser.cpp:4573
> +	   if (argumentNumber > 1)
> +	       unitFlags = unitFlags | FNonNeg;

Ditto.