[webkit-reviews] review granted: [Bug 90046] Implement sticky positioning : [Attachment 153701] Add support for parsing -webkit-sticky (depends on previous patch)

[bugzilla-daemon at webkit.org]

Ojan Vafai (vacation through 7/31) <ojan at chromium.org> has granted Simon Fraser
(smfr) <simon.fraser at apple.com>'s request for review:
Bug 90046: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Attachment 153701: Add support for parsing -webkit-sticky (depends on previous
patch)
https://bugs.webkit.org/attachment.cgi?id=153701&action=review

------- Additional Comments from Ojan Vafai (vacation through 7/31)
<ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153701&action=review


Typically we do one patch per bug, no?

Also, you're ChangeLog files are all messed up (out of order + OOPs lines).

The change itself looks good. :)

> LayoutTests/fast/css/sticky/resources/parsing-position-sticky.js:1
> +description("This tests checks that the -webkit-sticky value for position
parses correctly.");

Can we inline this into parsing-position-sticky.html? It makes sense to have
external JS files for tests that we want to run as pure-JS (e.g. in JSC), but
for these sorts of tests it just adds overhead to maintaining the test to have
it in a separate file.