[webkit-reviews] review denied: [Bug 91920] [WIN] Implement WebMutableURLRequest::setHTTPBody() : [Attachment 153661] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 91920: [WIN] Implement WebMutableURLRequest::setHTTPBody()
https://bugs.webkit.org/show_bug.cgi?id=91920

Attachment 153661: Patch
https://bugs.webkit.org/attachment.cgi?id=153661&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153661&action=review


> Source/WebKit/win/WebMutableURLRequest.cpp:298
> +    Vector<char, 1024> buffer(statstg.cbSize.QuadPart);

statstg.cbSize.QuadPart is a 64-bit unsigned integer. The Vector constructor
takes a size_t, which is a 32-bit unsigned integer on 32-bit systems. So this
will potentially overflow. We should probably return a failure result if
overflow will occur.

> Source/WebKit/win/WebMutableURLRequest.cpp:303
> +    if (FAILED(data->Read(buffer.data(), buffer.size(), &bytesRead)))
> +	   return E_FAIL;
> +
> +    m_request.setHTTPBody(FormData::create(buffer.data(), bytesRead));

It's too bad we can't read the data into the FormData directly. The extra copy
is unfortunate.