[webkit-reviews] review denied: [Bug 91963] Null-pointer crash when parsing border-image : [Attachment 153741] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 23 04:41:57 PDT 2012


Alexis Menard (darktears) <alexis.menard at openbossa.org> has denied
dstockwell at chromium.org's request for review:
Bug 91963: Null-pointer crash when parsing border-image
https://bugs.webkit.org/show_bug.cgi?id=91963

Attachment 153741: Patch
https://bugs.webkit.org/attachment.cgi?id=153741&action=review

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153741&action=review


> LayoutTests/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

The changelog is wrong here.

> LayoutTests/fast/css/border-image-fill-crash.html:7
> +    testRunner.dumpAsText();

You should use the new JS template for test, e.g.
fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html


More information about the webkit-reviews mailing list